-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: generate doc from specs #92
Conversation
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 6f2b95e 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/621f8f8fb4ed060008b4827c |
b5e9d63
to
744fb52
Compare
Just asking for a review to gather thoughts on this |
Light mode makes the page crash, good way to prevent users from burning their eyes |
I guess this is why only dark mode is available on their demo 🤔 |
Unless we want to go with a full-dark-mode I don't think we will be able to use this plugin. |
b0c5a54
to
8995fa6
Compare
8995fa6
to
ddb000e
Compare
I've added the docs here https://github.com/algolia/api-clients-automation/tree/main/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks very good, few more comments:
- Can you update your PR desc to reflect actual PR content
- There is an issue when you scroll, the top navbar disappear leaving a blank zone
- Can we log an issue on our side to use tags more extensively so endpoints can be grouped, cf: https://petstore.swagger.io/v2/swagger.json and results https://rohit-gohri.github.io/redocusaurus/examples/using-spec-url/#tag/user
- Currently the doc is mixing internal doc for this repo and external doc, is there any way to better split the two?
Done!
Do you mostly refer to the
Good catch, I believe Redocusaurus does not support the
For now |
Most API have implicit grouping that can not be split into sub-client. In the UI if you put tags, they can be split by Configs and Logs |
Ah yes make sense, however since it's the same specs that we use for the generation it would have an impact on that to add more tags to it, we need to do a bit of testing here |
Final review before merging anyone? Or an approval :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-260
Summary
This website is hosted on Netlify and built with Docusaurus.
We are using the Redocusaurus plugin to generate documentation for our bundled specs files
Deploys
You can have a preview of the website here: https://api-clients-automation.netlify.app/
Deploy will only happens when the
website
orspecs/bundled/
folder have changed.Feedbacks
🧪 Test