Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: generate doc from specs #92

Merged
merged 15 commits into from
Mar 2, 2022
Merged

docs: generate doc from specs #92

merged 15 commits into from
Mar 2, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 17, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-260

Summary

This website is hosted on Netlify and built with Docusaurus.

We are using the Redocusaurus plugin to generate documentation for our bundled specs files

Deploys

You can have a preview of the website here: https://api-clients-automation.netlify.app/

Deploy will only happens when the website or specs/bundled/ folder have changed.

Feedbacks

🧪 Test

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 6f2b95e

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/621f8f8fb4ed060008b4827c

@shortcuts shortcuts marked this pull request as draft January 18, 2022 08:44
@shortcuts shortcuts self-assigned this Jan 18, 2022
Base automatically changed from feat/APIC-256/specs-bundle to main January 18, 2022 13:09
@shortcuts shortcuts force-pushed the feat/APIC-260/api-doc branch from b5e9d63 to 744fb52 Compare January 20, 2022 17:13
@shortcuts shortcuts marked this pull request as ready for review January 21, 2022 12:19
@shortcuts
Copy link
Member Author

Just asking for a review to gather thoughts on this

@millotp
Copy link
Collaborator

millotp commented Jan 21, 2022

Light mode makes the page crash, good way to prevent users from burning their eyes

@shortcuts
Copy link
Member Author

Light mode makes the page crash, good way to prevent users from burning their eyes

I guess this is why only dark mode is available on their demo 🤔

@shortcuts
Copy link
Member Author

Unless we want to go with a full-dark-mode I don't think we will be able to use this plugin.

@shortcuts shortcuts changed the title docs(poc): generate doc from specs docs: generate doc from specs Feb 4, 2022
@shortcuts shortcuts force-pushed the feat/APIC-260/api-doc branch 4 times, most recently from b0c5a54 to 8995fa6 Compare February 24, 2022 08:57
@shortcuts shortcuts force-pushed the feat/APIC-260/api-doc branch from 8995fa6 to ddb000e Compare February 24, 2022 08:58
@shortcuts
Copy link
Member Author

@shortcuts shortcuts requested review from eunjae-lee and removed request for eunjae-lee and bodinsamuel February 24, 2022 09:27
@shortcuts shortcuts requested a review from bodinsamuel March 1, 2022 16:36
@shortcuts shortcuts enabled auto-merge (squash) March 1, 2022 16:36
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks very good, few more comments:

@shortcuts
Copy link
Member Author

Can you update your PR desc to reflect actual PR content

Done!

Can we log an issue on our side to use tags more extensively so endpoints can be grouped, cf:

Do you mostly refer to the search spec here? We've decided to try to split this one in smaller specs to avoid having everything under it

There is an issue when you scroll, the top navbar disappear leaving a blank zone

Good catch, I believe Redocusaurus does not support the hideOnScroll option

Currently the doc is mixing internal doc for this repo and external doc, is there any way to better split the two?

For now docs only hosts documentation for our repository, but we could have API client snippets under and other group yes

@bodinsamuel
Copy link
Contributor

Do you mostly refer to the search spec here? We've decided to try to split this one in smaller specs to avoid having everything under it

Most API have implicit grouping that can not be split into sub-client.
For example QS has:
/logs
/configs

In the UI if you put tags, they can be split by Configs and Logs

@shortcuts
Copy link
Member Author

Most API have implicit grouping that can not be split into sub-client.

Ah yes make sense, however since it's the same specs that we use for the generation it would have an impact on that to add more tags to it, we need to do a bit of testing here

@shortcuts shortcuts disabled auto-merge March 2, 2022 14:10
@shortcuts shortcuts requested a review from bodinsamuel March 2, 2022 14:10
@shortcuts
Copy link
Member Author

Final review before merging anyone? Or an approval :D

@shortcuts shortcuts enabled auto-merge (squash) March 2, 2022 14:10
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants