fix: search index spec #8
Conversation
|
Error I got, you got to love an API that only output one error without context {
"message": "Unknown parameter: userData",
"status": 400
}
{
"message": "Unknown response field `string`",
"status": 400
}
{
"message": "Unknown parameter: attributeForDistinct",
"status": 400
}
{
"message": "Value too small for \"minimumAroundRadius\" parameter, expected integer between 1 and 9223372036854775807",
"status": 400
}
{
"message": "Invalid value for \"aroundRadius\" parameter, expected integer > 0",
"status": 400
} |
|
@millotp @damcou @shortcuts not sure I will have time tomorrow (tuesday), do not hesitate to continue this PR. |
Do you mean forwarding the message sent by the engine but changing the status code? |
It was more about writing all possible messages and do a |
| @@ -0,0 +1,85 @@ | |||
| allowCompressionOfIntegerArray: | |||
There was a problem hiding this comment.
Since we already have indexSettings params, 1/indexes/{indexName}/settings should be pretty easy
| /** | ||
| * A single record | ||
| */ | ||
| export class Record extends null<String, object> { |
There was a problem hiding this comment.
I don't get where this extends null is coming from but it's breaking the js, do you know how it got here ?
There was a problem hiding this comment.
Don't forget to commit the build if you have found the solution
There was a problem hiding this comment.
I can't find where this is coming from, it's just every other model but it adds a parent to this one
There was a problem hiding this comment.
additionalProperties: true adds this weird part, I did not find a solution yet 🤔
There was a problem hiding this comment.
Actually, modelError also have this type thing https://github.com/algolia/api-client-automation-experiment/blob/main/output/model/modelError.ts so it might be related to the generator template itself
|
Updated a bunch of things, might need an other review @damcou @bodinsamuel @millotp |
| _highlightResult: | ||
| $ref: '#/highlightResult' | ||
| _snippetResult: | ||
| $ref: '#/snippetResult' | ||
| _rankingInfo: | ||
| $ref: '#/rankingInfo' | ||
| _distinctSeqID: | ||
| type: number |
There was a problem hiding this comment.
Note, we should investigate if we can influence this response object with request param.
e.g: _rankingInfo is only return when getRankingInfo is true
There was a problem hiding this comment.
True, it was implemented as all optional for now but we should indeed make it clearer.
Should we consider it in this PR?
There was a problem hiding this comment.
no but we can note it in next investigation
| /** | ||
| * A single record | ||
| */ | ||
| export class Record extends null<String, object> { |
There was a problem hiding this comment.
Don't forget to commit the build if you have found the solution
Co-authored-by: Clément Vannicatte <[email protected]>
Spec for
/1/indexes/{indexName}/querytodo:
Mostly because SearchParams are incorrect