feat: query-suggestions client APIC-202 #74
Conversation
millotp
requested review from
shortcuts and
damcou
and removed request for
shortcuts
| '401': | ||
| $ref: ../../common/responses/Unauthorized.yml | ||
| '422': | ||
| $ref: ../common/responses/StatusUnprocessableEntity.yml | ||
| '500': | ||
| $ref: ../../common/responses/InternalError.yml |
There was a problem hiding this comment.
Are we sure other status are not handled? I believe the engine default status error for all endpoints, but I could be wrong
There was a problem hiding this comment.
My guess would be that some errors are documented and some not, we could do some tests to trigger them and see if it's global for all clients
e.g. 403 is declared as MethodNotAllowed on our clients
There was a problem hiding this comment.
I followed the doc but I'm sure some errors are missing, I'll add the common one
There was a problem hiding this comment.
In case you added you one, don't hesitate to add them to the common folder too. I wonder if we could have a global schema for all those responses
clients/algoliasearch-client-javascript/client-query-suggestions/model/models.ts
Outdated
Show resolved
Hide resolved
| * | ||
| * @param getAllConfigs - The getAllConfigs parameters. | ||
| */ |
There was a problem hiding this comment.
Those @param comments are fixed in #77
specs/query-suggestions/common/schemas/QuerySuggestionsIndex.yml
Outdated
Show resolved
Hide resolved
| content: | ||
| application/json: | ||
| schema: | ||
| type: array |
There was a problem hiding this comment.
Does it really return an array directly? :mad:
| '422': | ||
| $ref: ../../common/responses/StatusUnprocessableEntity.yml |
There was a problem hiding this comment.
I guess we should add it to all our endpoints 🤔
There was a problem hiding this comment.
We should test first, not sure how to trigger this error
🧭 What and Why
🎟 JIRA Ticket: APIC-202
Create the query-suggestions client
Changes included:
qstoquery-suggestionsbecause it's not worth it🧪 Test
CI