-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update versions of java and php packages #645
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
config/clients.config.json
Outdated
@@ -2,7 +2,7 @@ | |||
"java": { | |||
"folder": "clients/algoliasearch-client-java-2", | |||
"gitRepoId": "algoliasearch-client-java-2", | |||
"packageVersion": "0.0.1", | |||
"packageVersion": "4.0.0-alpha.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this to 4.0.0-SNAPSHOT
pls ? I guess you need to remove the SNAPSHOT
everywhere else then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN401
Ah, IIUC, does SNAPSHOT
sort of mean "It's still WIP"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it will be published on a different repository that people need to target specifically to have this version, it won't get updated automatically for people that are already using the client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait you also need to remove SNAPSHOT
from the templates
Ah yes indeed, |
Ah I got what you mean now |
if the |
algolia/api-clients-automation#645 Co-authored-by: Eunjae Lee <[email protected]>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-511
Changes included: