Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update versions of java and php packages #645

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jun 7, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-511

Changes included:

@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit bc6b8b6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/629f4819c0daa90008229e64

@eunjae-lee eunjae-lee marked this pull request as draft June 7, 2022 12:07
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 7, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@@ -2,7 +2,7 @@
"java": {
"folder": "clients/algoliasearch-client-java-2",
"gitRepoId": "algoliasearch-client-java-2",
"packageVersion": "0.0.1",
"packageVersion": "4.0.0-alpha.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to 4.0.0-SNAPSHOT pls ? I guess you need to remove the SNAPSHOT everywhere else then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN401

Ah, IIUC, does SNAPSHOT sort of mean "It's still WIP"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it will be published on a different repository that people need to target specifically to have this version, it won't get updated automatically for people that are already using the client

@eunjae-lee eunjae-lee marked this pull request as ready for review June 7, 2022 12:31
@eunjae-lee eunjae-lee requested review from millotp and shortcuts June 7, 2022 12:31
shortcuts
shortcuts previously approved these changes Jun 7, 2022
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait you also need to remove SNAPSHOT from the templates

@shortcuts
Copy link
Member

wait you also need to remove SNAPSHOT from the templates

Ah yes indeed, -SNAPSHOT is appended in them

@eunjae-lee
Copy link
Contributor Author

wait you also need to remove SNAPSHOT from the templates

Ah I got what you mean now

@millotp
Copy link
Collaborator

millotp commented Jun 7, 2022

if the -SNAPSHOT is present in clients.config.json il will be generated into gradle.properties, and the check is still valid

@eunjae-lee eunjae-lee merged commit 79c7966 into main Jun 7, 2022
@eunjae-lee eunjae-lee deleted the chore/update-vers branch June 7, 2022 15:10
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants