Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Insights client specs + javascript insights client #62

Merged
merged 14 commits into from
Jan 6, 2022

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jan 5, 2022

This PR includes:

@damcou damcou requested review from millotp and shortcuts January 5, 2022 14:58
@shortcuts shortcuts force-pushed the feat/APIC-205/insights-client branch from 174420d to 4c78394 Compare January 6, 2022 09:21
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job !

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, GG!

templates/javascript/api-single.mustache Outdated Show resolved Hide resolved
specs/insights/paths/pushEvents.yml Outdated Show resolved Hide resolved
specs/insights/paths/pushEvents.yml Outdated Show resolved Hide resolved
@damcou damcou requested review from millotp and shortcuts January 6, 2022 10:50
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants