-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generated files from splitted specs #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's working, we could really improve the DX !
batchObject: BatchObject, | ||
options: { headers: { [name: string]: string } } = { headers: {} } | ||
): Promise<{ response: http.IncomingMessage; body: BatchResponse }> { | ||
const localVarPath = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove those localVar
prefixes with the templates
@@ -5,16 +5,14 @@ const client = new SearchApi(); | |||
async function testClient() { | |||
// test openapi gen | |||
try { | |||
const res = await client.search( | |||
[ | |||
const res = await client.multipleQueries('R2IYF7ETH7', 'e1e920e59f457ec70473486171c1d3b6', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should put those in a .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We can indeed dig in the template to make the output less verbose maybe
'/1/indexes/{indexName}/batch'.replace( | ||
'{' + 'indexName' + '}', | ||
encodeURIComponent(String(indexName)) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this generated or you did it manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it's generated, we should see how it's done so we can maybe use it for the init method.
…ted-files feat: add generated files from splitted specs
API-157