chore: use the multiplexer for the playground #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
reviewed
Jan 4, 2022
Comment on lines
+10
to
+11
| lang=$1 | ||
| client=$2 |
There was a problem hiding this comment.
can we exit for all like in https://github.com/algolia/api-clients-automation/blob/main/scripts/multiplexer.sh#L5-L9 ?
There was a problem hiding this comment.
Nothing will break if you run all playground at the same time, it will just look ugly, It's possible to block it like this but not sure if it's necessary
There was a problem hiding this comment.
Yep but what I meant is it's not intended to run all of them
shortcuts
previously approved these changes
Jan 4, 2022
shortcuts
reviewed
Jan 4, 2022
scripts/multiplexer.sh
Outdated
| @@ -19,6 +19,12 @@ CMD=$1 | |||
| LANGUAGE=$2 | |||
| CLIENT=$3 | |||
|
|
|||
| if [[ $CMD == "./scripts/playground.sh" ]] && [[ $LANGUAGE == "all" ]] || [[ $CLIENT == "all" ]]; then | |||
There was a problem hiding this comment.
Suggested change
| if [[ $CMD == "./scripts/playground.sh" ]] && [[ $LANGUAGE == "all" ]] || [[ $CLIENT == "all" ]]; then | |
| if [[ $CMD == "./scripts/playground.sh" && $LANGUAGE == "all" ]] || [[ $CLIENT == "all" ]]; then |
I believe it should be
There was a problem hiding this comment.
I did it with parentheses
shortcuts
approved these changes
Jan 4, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Replace all the script in
package.jsonbyyarn docker playground javascript searchusing the commonmultiplexerscript.It is not intended to be used with
allbut it's possible anyway.Changes included:
🧪 Test
yarn docker playground java