fix(generators): bunch of improvements on generator, and 140 width in java #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
requested review from
shortcuts and
eunjae-lee
and removed request for
shortcuts
|
lol |
shortcuts
approved these changes
May 25, 2022
| { | ||
| "files": "*.java", | ||
| "options": { | ||
| "printWidth": 140 |
| private List<Object> getPackageDependencies() { | ||
| List<Object> result = new ArrayList<Object>(); | ||
| @Override | ||
| public void addDataToBundle(Map<String, Object> bundle) throws GeneratorException { |
There was a problem hiding this comment.
Does addDataToBundle happens before addExtraToBundle?
There was a problem hiding this comment.
addExtraToBundle was a wrapper to catch and exit in case of exception, but this is already handled by the caller, so this function is gone and we call addDataToBundle directly.
This was referenced May 25, 2022
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
A bit of rework on generators, to have a more standard way of doing them.
The data is supposed to flow from top to bottom, in this order:
processOptionsfromOperationpostProcessOperationsWithModelspostProcessAllModelsI've reworked the error handling a bit and harmonized the code.
Since we are in 2022 and everyones owns a 4K monitor I've increased the maximum line length from 80 to 140 char, because it was unreadable in some place (this will create lots of change in the generated client, for the better).
🧪 Test
CI