chore(ci): close generation comment with last commit #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
millotp
force-pushed
the
chore/close-comment
branch
from
788e762 to
2ba72c1
Compare
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Clément Vannicatte <[email protected]>
This was referenced May 19, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
When there is no code gen, the comment is never updated, we need to run the
pushGeneratedCodein any case.Include the last generated commit in the closed comment because it's not actually deleted and can be useful
I had to mock some functions for tests.
🧪 Test
CI