feat(generators): factor utilsPackageVersion for JavaScript
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
shortcuts
force-pushed
the
feat/utilsPackageVersion-factor
branch
from
baa4ce3 to
840a703
Compare
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
I tried #485 locally with a rebase it seems to work, but you can rebase your branch to ensure it @bodinsamuel |
millotp
reviewed
May 18, 2022
generators/src/main/java/com/algolia/codegen/cts/manager/JavaCtsManager.java
Outdated
Show resolved
Hide resolved
eunjae-lee
reviewed
May 18, 2022
shortcuts
force-pushed
the
feat/utilsPackageVersion-factor
branch
from
8a2c02f to
8b92804
Compare
shortcuts
force-pushed
the
feat/utilsPackageVersion-factor
branch
from
8b92804 to
86fcb3d
Compare
millotp
approved these changes
May 18, 2022
| import type { Language } from './types'; | ||
| import type { Language, LanguageConfig } from './types'; | ||
|
|
||
| export function getClientsConfigField( |
There was a problem hiding this comment.
ahah how to overcomplicate thing, I agree that this is needed for Java but for ts we can just read json as is, but make sense for error checking
There was a problem hiding this comment.
Offers a way to avoid having a method for each field as @eunjae-lee suggested and also throws for all cases :D
This was referenced May 19, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
When generating a new JavaScript client, the default
utilsPackageVersionwill match the client version (e.g. #485 tries to fetch0.0.1of utils)This PR aims at applying the same logic added for
packageVersion:utilsPackageVersioninconfig/clients.config.jsongetPackageVersionlogic to the whole client config to be able to retrieve other fields🧪 Test
CI :D