Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php): make requestOptions match other clients #497

Merged
merged 1 commit into from
May 12, 2022
Merged

fix(php): make requestOptions match other clients #497

merged 1 commit into from
May 12, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented May 12, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-483

Changes included:

  • Remove some logic in the RequestOptionsFactory to make the parameter shape match other clients
  • Store header parameters in $headers
  • Remove unused parameter

Javascript:

  • Make requestOptions override default parameters

🧪 Test

CI :D

@shortcuts shortcuts requested review from damcou and a team May 12, 2022 09:26
@shortcuts shortcuts self-assigned this May 12, 2022
@shortcuts shortcuts requested review from eunjae-lee and removed request for a team May 12, 2022 09:26
@netlify
Copy link

netlify bot commented May 12, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit bae5c3e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/627cd2df4d721900093c0f4d

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 12, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

damcou
damcou approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice simplification 🚀

@shortcuts shortcuts merged commit 8727ddc into main May 12, 2022
@shortcuts shortcuts deleted the fix/requestOptions-javascript-php branch May 12, 2022 10:13
@damcou damcou mentioned this pull request May 13, 2022
Merged
This was referenced May 19, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee eunjae-lee is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @damcou