fix(templates): make queryParameters naming consistent
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
shortcuts
force-pushed
the
fix/queryParameters-naming
branch
from
8483b34 to
7a9bb05
Compare
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
commented
May 11, 2022
| @@ -16,4 +16,4 @@ jobs: | |||
| - name: Pull Request title rules | |||
| uses: deepakputhraya/[email protected] | |||
| with: | |||
| regex: '^(docs|chore)|((?:feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)\((?:generator|javascript|php|java|cts|spec|script|ci)\)): .+' | |||
| regex: '^(docs|chore)|((?:feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)\((?:generators|javascript|php|java|cts|specs|scripts|ci|templates)\)): .+' | |||
There was a problem hiding this comment.
folder files etc are all using plural form so it's reflected here too
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
|
What do we do now that it's a tie ? :p |
damcou
approved these changes
May 11, 2022
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
While implementing the CTS for the
requestOptionsI realized we re-introduced inconsistency in the naming.edit: Draft until we know if we go with
queryParamsorqueryParametersedit2:
queryParameterswon the polledit3: it's a tie again
edit4: team
queryParamsforfeit🧪 Test
CI :D