Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spec): finish tags #483

Merged
merged 7 commits into from
May 9, 2022
Merged

fix(spec): finish tags #483

merged 7 commits into from
May 9, 2022

Conversation

bodinsamuel
Copy link
Contributor

🧭 What and Why

Changes included:

  • Perso
  • QS
  • Predict
  • Reco
  • Sources

🧪 Test

yarn website
BUNDLE_WITH_DOC=true DOCKER=true yarn cli build specs all

@bodinsamuel bodinsamuel self-assigned this May 9, 2022
@netlify
Copy link

netlify bot commented May 9, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fcbe505
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62791d4b4070b70008a3aabb
😎 Deploy Preview https://deploy-preview-483--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 9, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@bodinsamuel bodinsamuel requested review from a team, millotp and shortcuts and removed request for a team May 9, 2022 13:35
shortcuts
shortcuts previously approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N I C E

specs/personalization/paths/deleteUserProfile.yml Outdated Show resolved Hide resolved
specs/personalization/paths/deleteUserProfile.yml Outdated Show resolved Hide resolved
specs/recommend/paths/getRecommendations.yml Outdated Show resolved Hide resolved
shortcuts
shortcuts reviewed May 9, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I did not wanted to approve but I did 🤷🏼

shortcuts
shortcuts approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :D

@bodinsamuel
Copy link
Contributor Author

thanks for the review ☺️
still can't merge 😬

millotp
millotp approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good ! Thank you !

@millotp millotp merged commit f8cee69 into main May 9, 2022
@millotp millotp deleted the fix/tags-end branch May 9, 2022 14:19
This was referenced May 19, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 25, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@millotp millotp millotp approved these changes

Assignees

@bodinsamuel bodinsamuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bodinsamuel @algolia-bot @millotp @shortcuts