fix(ci): forgot the no codegen message #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
eunjae-lee and
damcou
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
May 9, 2022
| @@ -7,13 +7,14 @@ import TabItem from '@theme/TabItem'; | |||
|
|
|||
| <Tabs | |||
There was a problem hiding this comment.
yep I forgot to rebase
shortcuts
reviewed
May 9, 2022
.github/actions/setup/action.yml
Outdated
| @@ -92,7 +92,7 @@ runs: | |||
| echo "::set-output name=RUN_JS_ALGOLIASEARCH::true" | |||
| fi | |||
|
|
|||
| if [[ ${{ steps.diff.outputs.JS_UTILS_CHANGED }} > 0 ]]; then | |||
| if [[ ${{ steps.diff.outputs.JS_UTILS_CHANGED }} > 0 || ${{ steps.diff.outputs.JS_CLIENT_CHANGED }} > 0 ]]; then | |||
There was a problem hiding this comment.
Ah it's because it's actually base_changed that is triggered here. It could maybe be useful that https://github.com/algolia/api-clients-automation/blob/main/scripts/ci/githubActions/createMatrix.ts#L74-L78 sets an output variable for the language like BASE_<LANGUAGE_NAME>_CHANGED
There was a problem hiding this comment.
good idea, I think it works that way
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The CI was not editing the message when no code is generated.
Changes included:
pushGeneratedCodescript🧪 Test
CI