chore: fix specs deps #478
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Yep we could definitely make keys more describing too |
So if I understand correctly, every *_CHANGED key means that you have to run the corresponding job depending on if the related files have changed ? In that case I agree it can be changes as Pierre suggested. |
| @@ -133,7 +133,7 @@ outputs: | |||
| value: ${{ | |||
| steps.diff.outputs.GITHUB_ACTIONS_CHANGED > 0 || | |||
| steps.diff.outputs.SCRIPTS_CHANGED > 0 || | |||
| steps.diff.outputs.SPECS_CHANGED > 0 || | |||
| steps.diff.outputs.SHOULD_RUN_SPECS > 0 || | |||
There was a problem hiding this comment.
If it's only used here then you can remove the check for TEMPLATE_CHANGED, as it's included in SHOULD_RUN_SPECS
There was a problem hiding this comment.
I'd be in favor of doing the clean in a later PR as I'm not sure anything else won't break D:
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
(Sorry for all the issues)
specsjob should run whenever a client needs to run, see issue on #475🧪 Test
CI :D