Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cts): make tests less verbose #453

Merged
merged 3 commits into from
Apr 29, 2022
Merged

fix(cts): make tests less verbose #453

merged 3 commits into from
Apr 29, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

While writing tests, I felt like ours were adding a lot of new lines everywhere.

Fun fact: Oneliners in mustache outputs empty lines, which confirms that less is more 🤔

🧪 Test

CI :D

@shortcuts shortcuts requested review from a team, eunjae-lee and millotp and removed request for a team April 29, 2022 09:23
@netlify
Copy link

netlify bot commented Apr 29, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 6f25543
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/626bc71e0a194c0009faf15d

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 29, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts self-assigned this Apr 29, 2022
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no formatter for java or php?

@shortcuts
Copy link
Member Author

no formatter for java or php?

Sure there is but it keeps one line in between statements usually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants