Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: less cache calls #444

Merged
merged 3 commits into from
Apr 28, 2022
Merged

chore: less cache calls #444

merged 3 commits into from
Apr 28, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 28, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

429s are annoying.

  • Use @action/cache v3
  • Format 900 char long lines
  • Prevent restoring all specs on client matrix
    • We use an input to only restore the current client specs, which reduce the number of spec cache calls in a matrix job to 1, and prevent restoring specs for algoliasearch
    • Only restore clients related to algoliasearch on its job.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Apr 28, 2022
@netlify
Copy link

netlify bot commented Apr 28, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit b19dc46
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/626a5d6f8f18cd00088d3f92

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 28, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts marked this pull request as ready for review April 28, 2022 09:21
@shortcuts shortcuts requested review from a team, eunjae-lee and millotp and removed request for a team April 28, 2022 09:21
@shortcuts shortcuts enabled auto-merge (squash) April 28, 2022 10:27
millotp
millotp approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great ! Let's measure the CI now 😛

@shortcuts shortcuts merged commit fa07bdf into main Apr 28, 2022
@shortcuts shortcuts deleted the chore/cache-calls branch April 28, 2022 12:02
This was referenced Apr 29, 2022
Closed
Closed
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee eunjae-lee is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp