Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): make http(s) agent global #44

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix(js): make http(s) agent global #44

merged 2 commits into from
Dec 16, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Dec 16, 2021 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Reflect algolia/algoliasearch-client-javascript#1216 to make the http and https agent global

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Dec 16, 2021
@shortcuts shortcuts mentioned this pull request Dec 16, 2021
Merged
millotp
millotp previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice I didn't know it would affect anything !

bodinsamuel
bodinsamuel previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏻
I did not commented it last time, that's problably why the information was lost, maybe it's worth adding a comment

@shortcuts shortcuts dismissed stale reviews from bodinsamuel and millotp via 5fba1dc December 16, 2021 10:54
@shortcuts shortcuts merged commit 752da0e into main Dec 16, 2021
@shortcuts shortcuts deleted the fix/javascript-agent branch December 16, 2021 11:06
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
fix(js): make http(s) agent global (#44)
0d45073
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodinsamuel bodinsamuel bodinsamuel approved these changes

@millotp millotp millotp approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @bodinsamuel @millotp