feat(cts): add algoliasearch-lite #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
shortcuts
commented
Apr 27, 2022
Comment on lines
144
to
151
| if (!operations.containsKey(operationId)) { | ||
| throw new CTSException( | ||
| // We only inform that it does not exist but skip the test generation | ||
| System.out.println( | ||
| "operationId " + operationId + " does not exist in the spec" | ||
| ); | ||
|
|
||
| continue; | ||
| } |
There was a problem hiding this comment.
This can be much more conditional if we want to keep throwing, but we could only skip for algoliasearch-lite.
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Apr 27, 2022
generators/src/main/java/com/algolia/codegen/cts/AlgoliaCtsGenerator.java
Outdated
Show resolved
Hide resolved
eunjae-lee
reviewed
Apr 27, 2022
generators/src/main/java/com/algolia/codegen/cts/AlgoliaCtsGenerator.java
Outdated
Show resolved
Hide resolved
millotp
reviewed
Apr 27, 2022
| @@ -146,20 +146,20 @@ public Map<String, Object> postProcessSupportingFileData( | |||
| language | |||
| ); | |||
|
|
|||
| for (Entry<String, Request[]> entry : cts.entrySet()) { | |||
| for (Entry<String, CodegenOperation> entry : operations.entrySet()) { | |||
There was a problem hiding this comment.
no sorting of operations ?
There was a problem hiding this comment.
Ah that's what's missing I forgot!!
There was a problem hiding this comment.
wouhou it works b3a3600
millotp
approved these changes
Apr 27, 2022
This was referenced Apr 28, 2022
This was referenced Apr 29, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
When generating tests for
algoliasearch-lite(only available in JavaScript), we now redirect to thesearchrequests folder, which will generate tests for the available methods only.🧪 Test
CI :D