Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): display skipped commits in release issue #434

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Apr 26, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-372

Changes included:

It updates the release issue to display skipped commits.

example1.

ScreenShot 2022-04-26 at 16 04 42@2x

example2.

ScreenShot 2022-04-26 at 16 04 27@2x

🧪 Test

  • CI

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 1d263b6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6267fd0b12ecb600089afa65

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 26, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@eunjae-lee eunjae-lee marked this pull request as ready for review April 26, 2022 14:13
@eunjae-lee eunjae-lee requested review from a team, damcou and shortcuts and removed request for a team April 26, 2022 14:23
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good! So if we have commits in one of those two list, and we remove it from the issue to put it under a language, will it be included in the changelog?

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, meant to approve, my comment isn't blocking

@eunjae-lee
Copy link
Contributor Author

That's good! So if we have commits in one of those two list, and we remove it from the issue to put it under a language, will it be included in the changelog?

Actually you can directly modify the changelog section, and the release process will parse it. No need to modify this list for that.

@shortcuts
Copy link
Member

shortcuts commented Apr 26, 2022

Actually you can directly modify the changelog section, and the release process will parse it. No need to modify this list for that.

Yep that's what I meant, is picking a commit from the commitsWithoutLanguageScope section and putting it at the javascript level will put it in the javascript changelog on issue close

but I guess you answered yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants