feat(java): release process (take 2) APIC-411 #422
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -4,7 +4,6 @@ | |||
| .mtj.tmp/ | |||
There was a problem hiding this comment.
this should have been unstaged 🤔
.github/actions/cache/action.yml
Outdated
| @@ -380,12 +380,13 @@ runs: | |||
| if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }} | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: clients/algoliasearch-client-java-2 | |||
| path: | | |||
| clients/algoliasearch-client-java-2/gradle.properties | |||
There was a problem hiding this comment.
Since it's the same for all clients, I think we can have a small block for this path only in this file and keep it in the check.yml file
There was a problem hiding this comment.
(So you don't have to put it in each block of this file)
There was a problem hiding this comment.
I don't get it, you want like a $ref ?
There was a problem hiding this comment.
I mean L378 for example you can add
- name: Restore Java client gradle properties
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-java-2/gradle.properties
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/bundled/search.yml',
'templates/java/**',
'generators/src/**'
)}}So you don't have to put it in every Java blocks in action.yml
There was a problem hiding this comment.
Will that work with the matrix ? because we also call the java cache here
There was a problem hiding this comment.
Yep I think it should work, you can leave the matrix as is
On the matrix: every steps will cache gradle.properties
On the cache: we only restore clients cache, the gradle.properties have its own block
There was a problem hiding this comment.
cool, I tried it here b4f83db
There was a problem hiding this comment.
Here it's removed, I think the matrix still needs to cache it
The goal is just to make it the cache file less verbose/conditional but idk if it works
There was a problem hiding this comment.
I think the cache actions will still try to execute for that block if I put job == client && language == java also
| @@ -98,7 +98,7 @@ jobs: | |||
| id: cache | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: ${{ matrix.client.bundledPath }} | |||
| path: ${{ format('specs/bundled/{0}.yml', matrix.client.name) }} | |||
There was a problem hiding this comment.
I still prefer manipulations in the TS file 😇
| @@ -1,10 +1,8 @@ | |||
| plugins { | |||
| id 'java-library' | |||
| id 'maven-publish' | |||
| id 'com.vanniktech.maven.publish' | |||
There was a problem hiding this comment.
I thought it was my last name ahaha
| matchedGenerator.api = `${clientName}Client`; | ||
| matchedGenerator.capitalizedName = clientName; | ||
| } | ||
| matchedGenerator.config = `${clientName}Config`; |
There was a problem hiding this comment.
This one is not relevant for clients other than PHP but not a big deal
There was a problem hiding this comment.
the gaol is to simplify a maximum, and remove all edge cases, it's not important if we have to much data passed to the yaml
| @@ -98,7 +98,7 @@ jobs: | |||
| id: cache | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: ${{ matrix.client.bundledPath }} | |||
| path: ${{ format('specs/bundled/{0}.yml', matrix.client.name) }} | |||
🧭 What and Why
🎟 JIRA Ticket: APIC-411
The first (#411) try had a lot of issues, mainly caching the right files, this should be correct.
🧪 Test
CI