chore(scripts): change dist folder and bump #4113
Merged
+219
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
approved these changes
Nov 15, 2024
|
I didn't find the deleted file but yes that might be the reason |
algolia-bot
added a commit
that referenced
this pull request
Nov 15, 2024
… ci] Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 15, 2024
algolia/api-clients-automation#4113 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
millotp
added a commit
that referenced
this pull request
Nov 18, 2024
millotp
added a commit
that referenced
this pull request
Nov 18, 2024
… ci] Co-authored-by: Pierre Millot <[email protected]>
Thanks @Sec32fun32 for your input! Could you please elaborate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The js release failed because tsc changed the output dir for some reason.
I tried releasing manually and failed so I had to bump all version a patch up and release on top of the buggy version.
This is very dirty and I have learned a lesson not to release on a friday night