Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: keep co-authors in spread commit #410

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Multiple co-authors are not kept in the spread commit, this (should) apply the same logic as in #375.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from eunjae-lee April 21, 2022 08:21
@shortcuts shortcuts self-assigned this Apr 21, 2022
@netlify
Copy link

netlify bot commented Apr 21, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 5c08ae7
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/626121969a03f4000926e339

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 21, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts marked this pull request as draft April 21, 2022 08:27
@shortcuts shortcuts force-pushed the chore/keep-co-authors-spread branch from 4b5f8dd to 232e039 Compare April 21, 2022 09:06
@shortcuts shortcuts marked this pull request as ready for review April 21, 2022 09:06
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but a little thing:

There's a mix of coauthor and coAuthor. It'd be nice to unify to coAuthor and coAuthors.

@shortcuts
Copy link
Member Author

shortcuts commented Apr 21, 2022

There's a mix of coauthor and coAuthor. It'd be nice to unify to coAuthor and coAuthors.

I wanted to avoid changing everything but I agree :D

@shortcuts shortcuts requested a review from eunjae-lee April 21, 2022 09:19
@shortcuts shortcuts enabled auto-merge (squash) April 21, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants