Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use different branch to test release #390

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

eunjae-lee
Copy link
Contributor

🧭 What and Why

Changes included:

  • This PR changes the main branch for release to main_test for the sake of the test.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 19, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 4732fee
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/625eb98e7edbae0008baa8cf

@eunjae-lee eunjae-lee requested review from a team, damcou and millotp and removed request for a team April 19, 2022 13:06
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also affect the generated code push, which is working fine I think, can you override just for the release process ?

@eunjae-lee
Copy link
Contributor Author

This will also affect the generated code push, which is working fine I think, can you override just for the release process ?

can you elaborate how it affects the generated code push?

@shortcuts
Copy link
Member

shortcuts commented Apr 19, 2022

can you elaborate how it affects the generated code push?

https://github.com/algolia/api-clients-automation/blob/main/scripts/ci/codegen/pushGeneratedCode.ts#L20 the codegen use this option, you can add a new one only for the release

@eunjae-lee
Copy link
Contributor Author

oh didn't know that. will update this. thx

@eunjae-lee
Copy link
Contributor Author

Actually, all I need to do is to check out the repository on main_test on release-process workflow. So this will do!

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I think that will work, don't forget to create the branch :)

@eunjae-lee eunjae-lee enabled auto-merge (squash) April 19, 2022 13:21
@eunjae-lee
Copy link
Contributor Author

I sent this PR before creating the branch, and the CI failed 😂 Now it's there!

@eunjae-lee eunjae-lee merged commit 6fde318 into main Apr 19, 2022
@eunjae-lee eunjae-lee deleted the chore/different-main-branch branch April 19, 2022 13:39
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
* chore(ci): use different branch to test release

* chore: process release on main_test branch

* chore: revert release.config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants