feat(clients): cleanup after replaceAllObjects failure [skip-bc] #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Fluf22
force-pushed
the
feat/rao-cleanup
branch
from
fb23191 to
fe22a38
Compare
Fluf22
force-pushed
the
feat/rao-cleanup
branch
from
8c86573 to
8682e0d
Compare
millotp
changed the title
shortcuts
approved these changes
Dec 31, 2024
|
|
||
| batchResp, err := c.ChunkedBatch(tmpIndexName, objects, ACTION_ADD_OBJECT, opts...) | ||
| if err != nil { | ||
| _, _ = c.DeleteIndex(c.NewApiDeleteIndexRequest(tmpIndexName)) |
There was a problem hiding this comment.
if we have a defer and it succeed, it doesn't noop? that's why you've added it everywhere?
There was a problem hiding this comment.
indeed, we don't want to make an extra call in case the final move succeeds
|
thanks a lot @Fluf22 for the help ! |
algolia-bot
added a commit
that referenced
this pull request
Dec 31, 2024
…) (generated) [skip ci] Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Dec 31, 2024
…erated) algolia/api-clients-automation#3824 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
DI-2928
closes algolia/algoliasearch-client-php#739
Whatever happens, at the end of the
replaceAllObjectshelper, the temporary index should not exists anymore.