Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "chore: release 2022-04-15" #381

Merged
merged 3 commits into from
Apr 15, 2022
Merged

chore: revert "chore: release 2022-04-15" #381

merged 3 commits into from
Apr 15, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

This reverts commit de833a8.

🧪 Test

@shortcuts shortcuts requested a review from a team April 15, 2022 08:24
@shortcuts shortcuts self-assigned this Apr 15, 2022
@shortcuts shortcuts requested review from eunjae-lee and damcou and removed request for a team April 15, 2022 08:24
@netlify
Copy link

netlify bot commented Apr 15, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 6c26fe8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/625931d2aa7a9d0008f63fb5

@shortcuts shortcuts changed the title Revert "chore: release 2022-04-15" chore: revert "chore: release 2022-04-15" Apr 15, 2022
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 15, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

eunjae-lee
eunjae-lee previously approved these changes Apr 15, 2022
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we don't really "need" to revert these release commits unless they actually broke something. They're mostly version bumping. And at this point, version doesn't matter much because it's @ experiemental/.

Anyway, feel free to revert!

@shortcuts
Copy link
Member Author

IMO, we don't really "need" to revert these release commits unless they actually broke something. They're mostly version bumping. And at this point, version doesn't matter much because it's @ experiemental/.

I still think it's better to erase all the noise and keep it clean even if it's experimental

@shortcuts shortcuts enabled auto-merge (squash) April 15, 2022 08:46
@shortcuts shortcuts merged commit a2d3b70 into main Apr 15, 2022
@shortcuts shortcuts deleted the revert/release branch April 15, 2022 09:04
@eunjae-lee
Copy link
Contributor

I thought I approved it when leaving that comment 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants