fix(javascript): add override to name property #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
approved these changes
Sep 20, 2024
algolia-bot
added a commit
that referenced
this pull request
Sep 20, 2024
…kip ci] Co-authored-by: Clément Vannicatte <[email protected]> Co-authored-by: Yannik Ache Eicher <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Sep 20, 2024
algolia/api-clients-automation#3785 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]> Co-authored-by: Yannik Ache Eicher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
imported from algolia/algoliasearch-client-javascript#1552
When using this library with the newest angular version (v18.2.2), the following error will be thrown.
You can "fix" the issue by using
noImplicitOverride: falsein thetsconfig, but I guess it would make sense to fix it here...This PR adds the missing
overrideproperty and should fix this issue.