fix(cts): remove default query parameters APIC-428 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
force-pushed
the
fix/remove-default
branch
3 times, most recently
from
66e1817 to
c15309a
Compare
millotp
force-pushed
the
fix/remove-default
branch
from
ceac697 to
92fd4ec
Compare
millotp
force-pushed
the
fix/remove-default
branch
from
16ea65f to
f30aa37
Compare
millotp
force-pushed
the
fix/remove-default
branch
from
f30aa37 to
b4534c4
Compare
millotp
requested review from
eunjae-lee and
damcou
and removed request for
a team
Co-authored-by: Clément Vannicatte <[email protected]>
This was referenced Apr 28, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-428
This removes the default value for the java client, replacing default with
null.This also simplifies the CTS by removing the
method, because it's always the same as the filename, theoperationIdand document a bit more the CTS.
Changes included:
datatobody(it only made sense for js)searchParamstoqueryParameters(same)method(alias to the filename)🧪 Test
CI