Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(ci): format json everywhere APIC-306 #376

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 13, 2022

🧭 What and Why

APIC-306

Format json everywhere to stop having different styling

This PR includes some generated code because it lint before the generation.

Changes included:

  • Use eslint-plugin-json-format
  • Format everywhere
  • Test on the CI

🧪 Test

yarn

@millotp millotp self-assigned this Apr 13, 2022
@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 6185f73
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62569cd22d4b6f000810cbba
😎 Deploy Preview https://deploy-preview-376--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@millotp millotp requested review from a team, eunjae-lee and shortcuts and removed request for a team April 13, 2022 09:50
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 13, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to push the clients package.json as the mustache is updated?

@millotp
Copy link
Collaborator Author

millotp commented Apr 13, 2022

As explained in the description I pushed the package.json because the linter runs in setup, before the generation. In other PR it won't be needed

@shortcuts
Copy link
Member

As explained in the description I pushed the package.json because the linter runs in setup, before the generation. In other PR it won't be needed

Ah yes otherwise it throws got it

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shortcuts
Copy link
Member

There was a ticket for this btw assign it to yourself

@millotp millotp merged commit 8fcdbc1 into main Apr 13, 2022
@millotp millotp deleted the style/format-json branch April 13, 2022 10:35
@millotp
Copy link
Collaborator Author

millotp commented Apr 13, 2022

Thanks I didn't see it

@millotp millotp changed the title style(ci): format json everywhere style(ci): format json everywhere APIC-306 Apr 13, 2022
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 13, 2022
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants