chore(ci): fix spread logic #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
eunjae-lee
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Apr 12, 2022
Comment on lines
71
to
81
| } else { | ||
| await configureGitHubAuthor(tempGitDir); | ||
| await run(`git add .`, { cwd: tempGitDir }); | ||
| await gitCommit({ | ||
| message: commitMessage, | ||
| coauthor: { name, email }, | ||
| cwd: tempGitDir, | ||
| }); | ||
| await run(`git push`, { cwd: tempGitDir }); | ||
| console.log(`✅ Spread the generation to ${lang} repository.`); | ||
| } |
There was a problem hiding this comment.
we can replace the return with continue; and keep the same logic
millotp
approved these changes
Apr 12, 2022
shortcuts
approved these changes
Apr 12, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Apr 12, 2022
algolia/api-clients-automation#372 Co-authored-by: Eunjae Lee <[email protected]>
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
* chore(ci): fix spread logic * chore: early continue
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Changes included:
It should not have returned. The return statement stopped the for-loop. I must've confused with forEach.