Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): skip spreading if there is no change #353

Merged
merged 10 commits into from
Apr 8, 2022
Merged

Conversation

eunjae-lee
Copy link
Contributor

🧭 What and Why

Changes included:

@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 79f2672
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62502e311e2a930009308849
😎 Deploy Preview https://deploy-preview-353--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 7, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@shortcuts shortcuts requested a review from millotp April 8, 2022 10:18
@shortcuts shortcuts enabled auto-merge (squash) April 8, 2022 10:18
@shortcuts shortcuts requested a review from damcou April 8, 2022 10:18
@shortcuts shortcuts requested a review from millotp April 8, 2022 12:10
@shortcuts shortcuts disabled auto-merge April 8, 2022 12:11
path: string;
}): Promise<number> {
cwd: string;
}>): Promise<number> {
const checkHead = head === null ? '' : `...${head}`;
Copy link
Collaborator

@millotp millotp Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, head can be undefined also, the line can be head ? `...${head}` : '';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does intentionally providing undefined invalidates the default HEAD value?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no you're right I got confused

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oki no problem

millotp
millotp previously approved these changes Apr 8, 2022
path: string;
}): Promise<number> {
cwd: string;
}>): Promise<number> {
const checkHead = head === null ? '' : `...${head}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no you're right I got confused

@shortcuts shortcuts merged commit 84fc7c2 into main Apr 8, 2022
@shortcuts shortcuts deleted the chore/safe-spread branch April 8, 2022 12:55
shortcuts added a commit that referenced this pull request Apr 22, 2022
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants