-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): automate with custom templates #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much comments on the generation, seems to work correctly.
The form however is not ideal. I don't have any knowledge about the templates, if we modify anything in the mustache we can no longer be in sync?
@bodinsamuel applied all (I think) your suggestions in ec47092 |
I guess we would have to diff the changes but indeed changes in mustache files are breaking |
At this point, do we want to commit on a tool (either openAPI or Swagger codegen) instead of doing the work for both ? (for the POC) |
I'm not sure to understand Edit: got it, sorry! I used OpenAPI since the output and the projects are similar, but I think we should choose one before doing the POC. I guess we could also try the paid feature from Swagger codegen before deciding |
Sorry, I was actually looking at the old package.json file locally, now I see that you used openAPI generator, so you can disregard this :| . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(did not check in details the spec itself)
ec47092
to
42a5d07
Compare
oops, it pushed the yarn cache file ._. |
@damcou @bodinsamuel repo and PR are cleaned, it will be easier to iterate |
feat(js): automate with custom templates
Notes
httpUserAgent
does not generate a custom user agenttypescript-node
mustache filesappId
is not passed to thehosts