Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix regression on release issue generation #275

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

eunjae-lee
Copy link
Contributor

🧭 What and Why

Changes included:

  • It fixes a regression which was introduced lately. readVersions failed because it didn't read versions correctly.

🧪 Test

  • New test is added

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 0860c24

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6239e710373f4200084ae8af

it('reads versions openapitools.json', () => {
expect(readVersions()).toEqual({
java: {
current: expect.any(String),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm checking with expect.any(String) instead of reading the real value from openapitools.json. I think it's enough to cover this regression.

@shortcuts
Copy link
Member

shortcuts commented Mar 22, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants