Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ci push yarn.lock updates #265

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Bumping version of the generated clients will update the yarn.lock, so we should also check for their changes.

It should be enough to fix #264

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team March 17, 2022 12:26
@shortcuts shortcuts self-assigned this Mar 17, 2022
@shortcuts shortcuts requested review from eunjae-lee and millotp and removed request for a team March 17, 2022 12:26
@netlify
Copy link

netlify bot commented Mar 17, 2022

✔️ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: d4c33af

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/62332908b25d72000864eec8

@shortcuts
Copy link
Member Author

shortcuts commented Mar 17, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@shortcuts shortcuts requested review from a team, eunjae-lee and damcou and removed request for eunjae-lee, millotp and a team March 17, 2022 12:33
@shortcuts shortcuts enabled auto-merge (squash) March 17, 2022 12:35
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ! maybe changelogs are generated too ?

@shortcuts shortcuts merged commit 3d5c440 into main Mar 17, 2022
@shortcuts shortcuts deleted the chore/codegen-ci-lock branch March 17, 2022 12:55
@shortcuts
Copy link
Member Author

Nice catch ! maybe changelogs are generated too ?

I'm not sure where they would be located for now, but yep I think there is still missing folder/files in this list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants