-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix CI matrix, fix job skipping #250
Conversation
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 578be2c 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/622f56dd869cd8000862830b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well ! All the cache key are name 1-blablabla
, can you add a description like before
please (1-search-spec-blablabla
) ? It's hard to debug otherwise
I've removed description from the Would you still want to see it? It would basically change from - name: Cache '${{ matrix.client }}' bundled specs
id: cache
uses: actions/cache@v2
with:
path: specs/bundled/${{ matrix.client }}.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
format('specs/{0}/**', matrix.client),
'specs/common/**'
)}} to - name: Cache '${{ matrix.client }}' bundled specs
id: cache
uses: actions/cache@v2
with:
path: specs/bundled/${{ matrix.client }}.yml
key: |
${{ env.CACHE_VERSION }}-${{
matrix.client
}}-spec-${{
hashFiles(
format('specs/{0}/**', matrix.client),
'specs/common/**'
)}}
|
You don't have to write it on multiple line, it can just be ${{ env.CACHE_VERSION }}-${{ matrix.client }}-spec-${{
hashFiles(
format('specs/{0}/**', matrix.client),
'specs/common/**'
)}} But I think it will help, in the |
You still have the context of the job etc. I still think it should not be tackled in this PR as it's a really verbose and repetitive change, it would be easier to review on an other one |
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-375
Changes included:
This PR contains a few CI fixes:
always
usage (opened issue: Job-level "if" condition not evaluated correctly if job in "needs" property is skipped actions/runner#491)success
status, we previously usedalways
which is not correct as the CI will keep running jobs even if previous one fails.CACHE_VERSION
from.cache_version
fileskips
forscripts
andcodegen
baseRef
variable (reading from its own output)🧪 Test
CI :D