Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI matrix, fix job skipping #250

Merged
merged 1 commit into from
Mar 14, 2022
Merged

chore: fix CI matrix, fix job skipping #250

merged 1 commit into from
Mar 14, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Mar 14, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-375

Changes included:

This PR contains a few CI fixes:

🧪 Test

CI :D

@shortcuts shortcuts requested a review from millotp March 14, 2022 14:53
@shortcuts shortcuts self-assigned this Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022

✔️ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 578be2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/622f56dd869cd8000862830b

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well ! All the cache key are name 1-blablabla, can you add a description like before
please (1-search-spec-blablabla) ? It's hard to debug otherwise

@shortcuts
Copy link
Member Author

Working well ! All the cache key are name 1-blablabla, can you add a description like before please (1-search-spec-blablabla) ? It's hard to debug otherwise

I've removed description from the key to ease the maintenance of the GitHub actions, it was taking at lot of "visual" space and was not helpful since we have their path on the CI (see screenshot).

Screenshot 2022-03-14 at 16 31 07

Would you still want to see it? It would basically change from

      - name: Cache '${{ matrix.client }}' bundled specs
        id: cache
        uses: actions/cache@v2
        with:
          path: specs/bundled/${{ matrix.client }}.yml
          key: |
            ${{ env.CACHE_VERSION }}-${{
            hashFiles(
              format('specs/{0}/**', matrix.client),
              'specs/common/**'
            )}}

to

      - name: Cache '${{ matrix.client }}' bundled specs
        id: cache
        uses: actions/cache@v2
        with:
          path: specs/bundled/${{ matrix.client }}.yml
          key: |
            ${{ env.CACHE_VERSION }}-${{
              matrix.client
            }}-spec-${{
            hashFiles(
              format('specs/{0}/**', matrix.client),
              'specs/common/**'
            )}}

@millotp
Copy link
Collaborator

millotp commented Mar 14, 2022

You don't have to write it on multiple line, it can just be

${{ env.CACHE_VERSION }}-${{ matrix.client }}-spec-${{
  hashFiles(
    format('specs/{0}/**', matrix.client),
    'specs/common/**'
)}}

But I think it will help, in the post restore cache step the path is not written for example

@shortcuts
Copy link
Member Author

But I think it will help, in the post restore cache step the path is not written for example

You still have the context of the job etc. I still think it should not be tackled in this PR as it's a really verbose and repetitive change, it would be easier to review on an other one

@shortcuts
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants