chore: make cache keys cleaner #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 8ae1a2f 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6228a096e21a1500092f8b42 |
eunjae-lee
reviewed
Mar 9, 2022
eunjae-lee
approved these changes
Mar 9, 2022
millotp
reviewed
Mar 14, 2022
| key: | | ||
| ${{ env.CACHE_VERSION }}-${{ | ||
| hashFiles( | ||
| 'clients/algoliasearch-client-java-2/client-predict/**', |
There was a problem hiding this comment.
didn't know java had the predict client already !
There was a problem hiding this comment.
ahaha yep that was a miss, it's fixed in #244
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Because cache keys were unreadable and hard to iterate on when working on GitHub actions.
keyto only keep relevant datahashFileswith multiple parametersIt is still pretty repetitive, but at least we can now read the file easier.
🧪 Test
CI :D