Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): add trending models #213

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Mar 2, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-346

Changes included:

To make it easier to review, the generated code is available in the stacked PR: #214

  • Add trending models for recommend spec
  • Remove in between searchParams reference

Closes #176

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team March 2, 2022 09:12
@shortcuts shortcuts self-assigned this Mar 2, 2022
@shortcuts shortcuts requested review from eunjae-lee and millotp and removed request for a team March 2, 2022 09:12
millotp
millotp previously approved these changes Mar 2, 2022
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! such details

specs/bundled/recommend.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[recommend]: add new strategies
2 participants