Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(javascript-tooling): add eslint #21

Merged
merged 5 commits into from
Dec 1, 2021
Merged

chore(javascript-tooling): add eslint #21

merged 5 commits into from
Dec 1, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Nov 30, 2021 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-82

Changes included:

  • Add eslint for the repository/javascript client (this should be split later but created out of scope changes)
  • Remove unused parameters from mustache files
  • Add description to all the specs

🧪 Test

  • yarn lint

@shortcuts
Copy link
Member Author

workflow_run is only triggered on main which is not right, I'll check how to fix that in an other PR

@shortcuts shortcuts marked this pull request as ready for review December 1, 2021 15:30
@shortcuts shortcuts requested review from millotp and damcou December 1, 2021 15:30
@shortcuts
Copy link
Member Author

I think I did not missed anything, but pretty hard to tell with all the changes.

millotp
millotp reviewed Dec 1, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
millotp
millotp approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! I can't see anything bad, the sooner we merge this the better !

@shortcuts
Copy link
Member Author

I'll merge now to avoid blockers on future iteration unless you have any review @damcou @bodinsamuel

@millotp millotp mentioned this pull request Dec 1, 2021
Merged
bodinsamuel
bodinsamuel approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shortcuts shortcuts merged commit 564b627 into main Dec 1, 2021
@shortcuts shortcuts deleted the chore/javascript-tooling branch December 1, 2021 17:21
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
chore(javascript-tooling): add eslint (#21)
4174219
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodinsamuel bodinsamuel bodinsamuel approved these changes

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @bodinsamuel @millotp