feat(script): use typescript for all scripts APIC-334 #170
Conversation
millotp
changed the title
|
include me as reviewer when ready for review. |
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
We definitely need a config folder
|
Can we have another script name than
|
|
did you know i was going to comment that, or did you make that change in the speed of light? 😂 |
|
ahah @shortcuts already proposed something similar #170 (comment) |
ahah I missed it lol |
| { language, key, additionalProperties: { packageName } }: Generator, | ||
| verbose: boolean | ||
| ): Promise<void> { | ||
| const spinner = createSpinner(`building ${key}`, verbose).start(); |
There was a problem hiding this comment.
it seems we don't want to call this function for non-js languages. what if we add throw just in case it's used wrongly in the future?
It's not exported, so it won't matter much. It's still easier to read if there's a short comment here and for buildAllClients.
| // generate clients to release | ||
| for (const lang of Object.keys(versionsToRelease)) { | ||
| console.log(`Generating ${lang} client(s)...`); | ||
| await run(`yarn cli generate ${lang}`); |
There was a problem hiding this comment.
you may want to give verbose: true here too?
There was a problem hiding this comment.
verbose shows the output of openapi generator and formatter which is very verbose, it should only be used when debugging IMO
🧭 What and Why
🎟 JIRA Ticket: APIC-334
Replace bash file by a beautiful typescript cli
Everything is called from one command,
yarn api, oryarn dockerto run it under docker (mandatory for local),with a helper and completion if you don't provide the arguments on local (maybe overkill). On CI it defaults to
all.ts-nodeis a bit too slow, it takes 9 seconds to launch, 6 with--transpile-onlyand 12 withswc(I think it's because of docker, it should be way faster). Maybe we could compile it and just standard js, but we don't want to build before each command, andts-nodegives us more visibility when failing, with error in ts source code.Improvements
🧪 Test
yarn dockerall commands