-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add settings
spec
#17
Conversation
Tried with the default template for the "duplicate" types, it's the same output so it's either a miss in my spec or a limitation of the generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I just had a really hard time to figure out how the attributes are ordered in the indexSettings.yml and SearchParams.yml now as the order is completely different from the specs. But I understand the union issues though.
As explained, I think that the name of the object are not self-explanatory enough, that's why I think you should add some comments like:
"params that are only used for index settings"
"params that are only used for search"
"params that are common to index settings and search"
Besides that I think this is really good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
7acca2b
to
c317c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, minor comments !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me !
Summary
settings
spec:getSettings
andsetSettings
methods403
errorspecs/common/responses/common.yml
content tospecs/common/parameters.yml
(used on other clients)common
(used on other clients)5.3.0
but that did not solve the disclaimerDisclaimer
There are a lot of duplicate types now, this is because the generator does not create complex types (e.g. with union) when using
allOf
/oneOf
but recreates a complete one instead.I did multiple combination and was not able to have a cleaner output than this one, but I'll keep trying 🤔
Generating from bundled spec file would solve this since it avoid duplication, but somehow openapi-generator does not resolve paths of bundled specs