-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(javascript): bundle CJS, ESM and UMD #135
Conversation
9e85ed7
to
405578e
Compare
…o requester package, works with jest
405578e
to
7242d9f
Compare
clients/algoliasearch-client-javascript/packages/client-common/src/createEchoRequester.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow tons of progress ! The flow is quite big, does it alter the creation process of a new client (create file by hand) or is it automatic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split this PR? I see lots of renames, and EchoRequester-related changes.
clients/algoliasearch-client-javascript/packages/client-analytics/tsconfig.json
Outdated
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/packages/client-analytics/package.json
Outdated
Show resolved
Hide resolved
I've tried to but all the changes are related to the build. I can do a stacked PR for the echo requester, but it's still required to scope the URL dependency of node/browser builds |
The flow should not change, it introduces a new |
I know it's really troublesome to manage stacked PRs, but it'd be much easier for me to review this PR if there's a PR dedicated to rollup and build process, and another one for the rest. |
38d7cc4
to
cf6be3f
Compare
I've kept the weird browser playground for you to test it if you want, but will make it cleaner before merging the PR |
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-232
The PR seems big but most of the changes are generated/from lock files.
Changes included:
CJS
,UMD
andESM
output for the JavaScript clients.browser
🧪 Test
CI :D