Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): catch up on deprecated github actions #1345

Merged
merged 5 commits into from
Feb 28, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 27, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-923

We have a lot of deprecation warning, for node 12 and for the set-output thing, but it's not supported in js so we have to do a workaround until this is fixed.

@millotp millotp self-assigned this Feb 27, 2023
@millotp millotp requested a review from a team as a code owner February 27, 2023 17:34
@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b6ff95e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63fdbeb7a1a5b1000735da68
😎 Deploy Preview https://deploy-preview-1345--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 27, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts previously approved these changes Feb 28, 2023
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect!

@millotp
Copy link
Collaborator Author

millotp commented Feb 28, 2023

it's only superficially unfortunately, the matrix is empty but should be full :(

@shortcuts
Copy link
Member

it's only superficially unfortunately, the matrix is empty but should be full :(

oh wow indeed, was I looking at the wrong run?

@millotp
Copy link
Collaborator Author

millotp commented Feb 28, 2023

the setOutput in js only works for the first call and then nothing

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:okidoki: gg

@millotp millotp merged commit e0b0ba3 into main Feb 28, 2023
@millotp millotp deleted the chore/deprecated-ga branch February 28, 2023 09:12
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Feb 28, 2023
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Feb 28, 2023
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants