Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add scopes to semantic #122

Merged
merged 2 commits into from
Feb 7, 2022
Merged

chore: add scopes to semantic #122

merged 2 commits into from
Feb 7, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Add scopes for our cts, specs and scripts.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from eunjae-lee February 7, 2022 11:10
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Singular vs plural? What do you think? I think singular might be easier to remember.

@shortcuts
Copy link
Member Author

Singular vs plural? What do you think? I think singular might be easier to remember.

I think we've mostly used plural since we are actively doing feat/fixes everywhere, but singular makes sense! b1173b8

@shortcuts shortcuts requested a review from eunjae-lee February 7, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants