Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean code generation and types #12

Merged
merged 6 commits into from
Nov 22, 2021
Merged

fix: clean code generation and types #12

merged 6 commits into from
Nov 22, 2021

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Nov 22, 2021

Remove broken parent code generation, until we understand why it's generated.
Rename Error to ErrorBase because it was interfering with the standard Error class.

Fix some timeouts (not yet correct for write operations).

Remove some unused code:

  • HttpError in favor of custom error
  • RequestFile

@millotp millotp requested review from damcou and shortcuts November 22, 2021 10:54
@millotp millotp self-assigned this Nov 22, 2021
shortcuts
shortcuts previously approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions but looks good!

Could you also update the README playground with the correct command?

clients/algoliasearch-client-javascript/utils/Requester.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
playground/javascript/app.ts Outdated Show resolved Hide resolved
specs/schemas/Record.yml Show resolved Hide resolved
templates/javascript/model.mustache Show resolved Hide resolved
shortcuts
shortcuts approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆🏼‍♂️

@millotp millotp merged commit 1963b8e into main Nov 22, 2021
@millotp millotp deleted the fix/types branch November 22, 2021 15:58
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
@millotp
fix: clean code generation and types (#12)
6001ac7
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millotp @shortcuts