Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store spec in CI script #113

Merged
merged 2 commits into from
Feb 3, 2022
Merged

fix: store spec in CI script #113

merged 2 commits into from
Feb 3, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 1, 2022

🧭 What and Why

Thanks to #78, @damcou spotted a bug in the CI spec script, that caused the CI to test multiple times each spec.

Changes included:

  • Add spec to a list and skip if it's already in the list

🧪 Test

CI

@millotp millotp requested a review from damcou February 1, 2022 14:38
@millotp millotp self-assigned this Feb 1, 2022
@millotp millotp requested a review from shortcuts February 3, 2022 08:54
shortcuts
shortcuts approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🤼

@millotp millotp merged commit 8fe7f4e into main Feb 3, 2022
@millotp millotp deleted the fix/ci-spec-script branch February 3, 2022 09:08
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
@millotp
fix: store spec in CI script (#113)
d8bf370
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millotp @shortcuts