-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repository): improve repository structure and naming #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth keeping the utils
folder with the outdated spec ?
I was also wondering if I should delete them or not, I guess we can keep them until we re-write the recommend specs |
Ah true the recommend is not in the |
return url; | ||
} | ||
|
||
export function serializeQueryParameters(parameters: Readonly<Record<string, any>>): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this PR: Is this function replacable with new UrlSearchParams?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is yes, some things are deprecated but I wanted to have the same behavior as the client at first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough, we might want to investigate after we have some test in place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked directly with you both, I like the new structure, just make sure that the current issue on setup will be fixed once the tests are generated ;)
Can you rename |
I've removed the old |
Summary
Since we want to go for a monorepo I thought it was needed to improve its structure so we can iterate on our tooling/other API clients in parallel.
There should be no code changes, only some renaming/restructuring.
Test
See the proposed structure here: https://github.com/algolia/api-client-automation-experiment/tree/chore/repository or locally