fix: improve script consistancy and format #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
millotp
force-pushed
the
fix/consistant-script
branch
from
586a07d to
5687a1c
Compare
shortcuts
reviewed
Jan 21, 2022
scripts/ci/create-spec-matrix.sh
Outdated
| @@ -4,11 +4,11 @@ BASE_CHANGED=$1 | |||
| BASE_BRANCH=$2 | |||
|
|
|||
| specs='{"client":[]}' | |||
There was a problem hiding this comment.
I tried to only capitalize global constants, and this is a variable.
There was a problem hiding this comment.
But where does the SPECS L11 come from?
There was a problem hiding this comment.
ok there is an issue here good catch
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The specs were kind of all over the place, this fixes the naming or global variables, simplify some scripts and add a common formatting script used by the client generation and the CTS.
🧪 Test
CI