-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hits): introduce hits fullpath in search results #183
feat(hits): introduce hits fullpath in search results #183
Conversation
Head's up that I need help and guidance to check if this is the best implementation. I was also encountering blockers from running local environment to test this properly. |
This looks like a great addtion! Can you share which blockers you faced on the local setup? |
@Jerska , i received the above error when running |
Hi @Jerska , following up on this if you are able to assist with pull request? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for a few cosmetic changes, this looks great to me, thank you for the Pull Request!
@sbellone WDYT?
Co-authored-by: Matthieu Dumont <[email protected]>
Co-authored-by: Matthieu Dumont <[email protected]>
Co-authored-by: Matthieu Dumont <[email protected]>
Thanks for the review and I've pushed your suggestions @Jerska ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition indeed!
I'll release. :) |
Had to fight the dependencies of all systems, but it's freshly released in |
thank you all! |
Creating PR for proposal added here: #182 (comment)