Allow #algolia_dirty?
to be defined privately
#430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Include all methods when determining whether an object responds to
#algolia_dirty?
.What problem is this fixing?
Object#send
can be used to call both public and private methods, butObject#respond_to?
only returnstrue
if the argument is a public method. This inconsistency is confusing.To be more consistent, either
#send
should be replaced with#public_send
, or#respond_to
should have its optionalinclude_all
argument set totrue
(in this PR I opted for the latter).There are many other places in the code that check if a method is defined publicly before calling it via
send
(checking if callbacks methods likeafter_commit
, etc are defined). I can update those as well if wanted. But#algolia_dirty?
seemed like the most critical, since that's the one end users would define themselves (rather than have defined by the framework they're using).