Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage-1095: Data Helper refactoring #1648

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Mage-1095: Data Helper refactoring #1648

merged 6 commits into from
Nov 27, 2024

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Nov 26, 2024

This PR includes:

  • Full refactoring of Algolia\AlgoliaSearch\Helper\Data:
    • All the logic related to index building has been moved to newly created classes called "Index Builders"
    • Kept the methods and mark them as "deprecated", they could theoretically be removed but we can let them until a next minor release.
    • Moved the getSearchResults() method to a dedicated BackendSearch Service
  • Created one IndexBuilder file per entity in the Service directory
  • Improved the Indexing Queue grid
    • Methods have now the same names, so the "class" column has been added to get a better view of the entities.
    • Better description what the job does (Full indexing or specific IDs indexing - see screenshot)
  • Removed all occurrences of the deprecated methods within the codebase.
  • Updated QueueTest file.

image

@damcou damcou requested a review from cammonro November 26, 2024 14:11
@damcou damcou self-assigned this Nov 26, 2024
cammonro
cammonro requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really GREAT work! 🙌

I added some suggestions. Please let me know what you think. Happy to chat further.

Model/Indexer/AdditionalSection.php Outdated Show resolved Hide resolved
Model/Indexer/Category.php Show resolved Hide resolved
Model/Indexer/Category.php Show resolved Hide resolved
Model/Source/JobMethods.php Show resolved Hide resolved
Model/Source/JobMethods.php Outdated Show resolved Hide resolved
Service/AbstractIndexBuilder.php Show resolved Hide resolved
Service/Category/IndexBuilder.php Outdated Show resolved Hide resolved
Service/Category/IndexBuilder.php Outdated Show resolved Hide resolved
Service/Product/BackendSearch.php Outdated Show resolved Hide resolved
view/adminhtml/ui_component/algolia_algoliasearch_indexing_queue_listing.xml Show resolved Hide resolved
@damcou damcou requested a review from cammonro November 27, 2024 10:47
cammonro
cammonro approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let 'er rip!

Model/Indexer/AdditionalSection.php Outdated Show resolved Hide resolved
Service/AbstractIndexBuilder.php Show resolved Hide resolved
@damcou damcou merged commit d61d854 into release/3.15.0-dev Nov 27, 2024
3 checks passed
@damcou damcou deleted the feat/MAGE-1095-data-helper-refactoring branch November 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammonro cammonro cammonro approved these changes

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damcou @cammonro